Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BGP Configuration on NSX-T Edge Gateways #480

Merged
merged 15 commits into from
Jul 26, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jun 3, 2022

This PR adds the initial structure for NSX-T Edge Gateway BGP Configuration. It reflects the "Configuration" tab in UI.

image

Additional test fixes to make test suite run better:

  • Route advertisement code uncovered a VCD flaw with tenant context IDs. Apparently, VCD 10.2.X does not accept URN formatted Org ID (only UUID). VCD 10.3 works fine with both. Commit f57dd01 introduced a global fix for this.
  • Some of the previous tests were leaking vApp templates and media items that would break Test_QueryVappTemplateList and Test_CatalogQueryMediaList. These tests are now patched to dump structures for these leaked templates so that they can be caught easier. As a result of this lookup these tests were patched to properly cleanup:
    • Test_AddAndDeleteMetadataOnMediaRecord
    • Test_AddNewVMFromMultiVmTemplate
    • Test_AnswerVmQuestion
  • All VCD versions currently have a bug that disables Catalog publishing on Org update. As a result Test_PublishToExternalOrganizations always fails as it assumes that publishing is enabled. To overcome it I added explicit patch for CanPublishCatalogs=true and CanPublishExternally=true before this test run.
  • There have been cases when ALB tests were probably hit by timing issues (looks like VCD needs a wait before kicking in a task to enable ALB on Edge Gateway). In this PR test helper setupAlbPoolPrerequisites is patched to perform cleanups better and avoid subsequent test failure. This should help tests to run cleaner and also find potential errors in the future.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius added 4 commits June 3, 2022 16:14
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review June 21, 2022 10:03
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions to the main PR topic. Yet, is always a philosophical question that should be in separate PR or not :)

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one ask and looks great!

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 113fc60 into vmware:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants