-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BGP Configuration on NSX-T Edge Gateways #480
Conversation
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions to the main PR topic. Yet, is always a philosophical question that should be in separate PR or not :)
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one ask and looks great!
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
This PR adds the initial structure for NSX-T Edge Gateway BGP Configuration. It reflects the "Configuration" tab in UI.
Additional test fixes to make test suite run better:
f57dd01
introduced a global fix for this.Test_QueryVappTemplateList
andTest_CatalogQueryMediaList
. These tests are now patched to dump structures for these leaked templates so that they can be caught easier. As a result of this lookup these tests were patched to properly cleanup:Test_AddAndDeleteMetadataOnMediaRecord
Test_AddNewVMFromMultiVmTemplate
Test_AnswerVmQuestion
Test_PublishToExternalOrganizations
always fails as it assumes that publishing is enabled. To overcome it I added explicitpatch
forCanPublishCatalogs=true
andCanPublishExternally=true
before this test run.setupAlbPoolPrerequisites
is patched to perform cleanups better and avoid subsequent test failure. This should help tests to run cleaner and also find potential errors in the future.