Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dhcp wait #481

Merged
merged 36 commits into from
Jun 8, 2022
Merged

Fix dhcp wait #481

merged 36 commits into from
Jun 8, 2022

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Jun 6, 2022

Fix: vmware/terraform-provider-vcd#666

verified that current test isn't broken:

START: vm_dhcp_test.go:26: TestVCD.Test_VMGetDhcpAddress
# Time out waiting for DHCP IPs on powered off VMs: OK
# Get IPs for NICs 0 and 1: OK:(NICs 0 and 1): 32.32.32.22, 32.32.32.21
# Get active lease for NICs with MAC 0: Ok. (Got active lease for MAC 0: 32.32.32.22)
# Check number of leases on Edge Gateway: OK: (4 leases found)
# Get IP for single NIC 0: OK: Got IP for NICs 0: 32.32.32.22
# Get IPs for NICs 0 and 1 (only using guest tools): OK: IPs for NICs 0 and 1 (via guest tools): 32.32.32.22, 32.32.32.21
PASS: vm_dhcp_test.go:26: TestVCD.Test_VMGetDhcpAddress	300.330s

START: api_vcd_test.go:1554: TestVCD.TearDownSuite
# 1 of 3 - removeLeftoverEntries: [INFO] Attempting cleanup of vapp 'TestSetUpSuite' instantiated by createTestVapp
removeLeftoverEntries: [INFO] Removed vapp 'TestSetUpSuite' created by createTestVapp
# 2 of 3 - removeLeftoverEntries: [INFO] Attempting cleanup of vapp 'GetDhcpAddress' instantiated by createTestVapp
removeLeftoverEntries: [INFO] No action for vapp 'GetDhcpAddress'
# 3 of 3 - removeLeftoverEntries: [INFO] Attempting cleanup of network 'TestCreateOrgVdcNetworkDhcp' instantiated by TestCreateOrgVdcNetworkDhcp
removeLeftoverEntries: [INFO] Removed network 'TestCreateOrgVdcNetworkDhcp' created by TestCreateOrgVdcNetworkDhcp
PASS: api_vcd_test.go:1554: TestVCD.TearDownSuite	59.053s

OK: 1 passed
PASS

new test isn't added as it will be big and complicated and we have limited NSXV support.

vbauzys and others added 30 commits August 25, 2020 08:55
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
# Conflicts:
#	govcd/api.go
#	govcd/api_vcd_test.go
#	govcd/openapi_endpoints.go
#	types/v56/constants.go
#	types/v56/openapi.go
@vbauzys vbauzys requested a review from Didainius June 6, 2022 10:50
@vbauzys vbauzys self-assigned this Jun 6, 2022
@vbauzys vbauzys marked this pull request as ready for review June 6, 2022 10:51
@vbauzys vbauzys removed the request for review from dataclouder June 6, 2022 10:51
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Contributor

@mikeletux mikeletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@vbauzys vbauzys merged commit 513b534 into vmware:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading NIC DHCP IP from NSX-V in vcd_vapp_vm (network_dhcp_wait_seconds parameter)
6 participants