Add support for Dynamic Security Groups #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Dynamic Security Groups (or as they are called in API - Firewall Groups).
It reuses the same functions we already have (because IP sets, Static Security Groups and Dynamic Security Groups use the same API), but expands a few places to accommodate Dynamic Security Group handling in VCD 10.3+:
types.NsxtFirewallGroup
with new fields introduced with API V36.0 (VCD 10.3)types.FirewallGroupTypeVmCriteria
to match Dynamic Security Group type of Firewall group.Test_NsxtDynamicSecurityGroup
to checkout Dynamic security group creation.NsxtFirewallGroup.IsDynamicSecurityGroup()
function to validate that given Firewall Group is Dynamic Security Group*VdcGroup
pointer receivergetFirewallGroupTypeFilterFieldName
for embedding into Security Group management functions as new fieldTypeValue
must be used instead of now deprecated oneType
which doesn't support Dynamic Firewall Groups.More about Dynamic Security Groups in VCD official docs and VMware Blog post: