Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dynamic Security Groups #487

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jun 30, 2022

This PR adds support for Dynamic Security Groups (or as they are called in API - Firewall Groups).
It reuses the same functions we already have (because IP sets, Static Security Groups and Dynamic Security Groups use the same API), but expands a few places to accommodate Dynamic Security Group handling in VCD 10.3+:

  • Expand types.NsxtFirewallGroup with new fields introduced with API V36.0 (VCD 10.3)
  • New constant types.FirewallGroupTypeVmCriteria to match Dynamic Security Group type of Firewall group.
  • API elevation to 36.0 when available so that Dynamic security groups can be handled.
  • Additional test Test_NsxtDynamicSecurityGroup to checkout Dynamic security group creation.
  • NsxtFirewallGroup.IsDynamicSecurityGroup() function to validate that given Firewall Group is Dynamic Security Group
  • Additional Firewall Group functions with *VdcGroup pointer receiver
  • Internal function getFirewallGroupTypeFilterFieldName for embedding into Security Group management functions as new field TypeValue must be used instead of now deprecated one Type which doesn't support Dynamic Firewall Groups.

More about Dynamic Security Groups in VCD official docs and VMware Blog post:

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius force-pushed the dynamic_groups-pr branch from 507fd76 to e24920f Compare June 30, 2022 12:18
@Didainius Didainius self-assigned this Jun 30, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review July 1, 2022 08:34
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few asks :)

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@lvirbalas lvirbalas removed the request for review from vbauzys July 15, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants