Add moref id to VM record type

[yusufozturk]

This PR adds VM moref id to VM record type struct.

Moref is already included in VM requests but it wasn't in the struct, so XML deserialization wasn't filling that.

Moref id helps us to match vCloud VM with vCenter VM.

Here is the issue:
#490

Thanks.

[vmwclabot]

@yusufozturk, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[adambarreiro]

Hi @yusufozturk,
Thanks a lot for the contribution.

Just a small suggestion, would it be possible to add a small assertion in Test_QueryVM in vdc_test.go?

vm, err := vcd.vdc.QueryVM(vcd.vapp.VApp.Name, vmName)
check.Assert(err, IsNil)
check.Assert(vm.VM.Name, Equals, vmName)

To check that vm.VM.Moref is populated and starts with vm- (if that's always the case, I'm not a big expert).

Currently that test is just checking the VM name so I thought this could help to improve it + validate your change.

Best regards.

[vmwclabot]

@yusufozturk, VMware has approved your signed contributor license agreement.

[yusufozturk]

@adambarreiro thanks. I added tests but somehow there are additional whitespaces. I will revert them back.

[yusufozturk]

@adambarreiro ready. I don't know how to run tests yet but I made the changes according to other tests.

Please let me know if you need anything else.

Thanks.

[Didainius]

Hello @yusufozturk,
Thank you for this PR. Tests works and we're happy to have it. I have just 2 asks:

• Do a make fmt (which does gofmt) as our automated check is failing https://github.com/vmware/go-vcloud-director/runs/7670417180?check_suite_focus=true
• Put a note to changelog. The way it works is we ask to put a file called 491-improvements.md (your PR number and type) into https://github.com/vmware/go-vcloud-director/tree/main/.changes/v2.17.0 (as this is 2.17 release cycle now). You can see how it worked for previous cycles (https://github.com/vmware/go-vcloud-director/tree/main/.changes/v2.16.0)

We're happy to merge it afterwards

[yusufozturk]

@Didainius thanks. I've made the changes.

[adambarreiro]

LGTM! Thanks a lot for the contribution!

[Didainius]

@yusufozturk ,
Thanks for PR - I have merged it in and it is now in main. I have tagged the code with your patch v2.17.0-alpha.1 if you want to consume it.