Simplify Test_LDAP #505
Merged
Simplify Test_LDAP #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove VM and network creation from LDAP test * Replace ephemeral VM with permanent LDAP server in the testing VCD * Remove functions that were only used to create the VM for this test Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius and
adambarreiro
as code owners
|
First review, all good imho! I'll run the tests and then approve. |
lvirbalas
approved these changes
Sep 19, 2022
adambarreiro
approved these changes
Sep 19, 2022
Didainius
approved these changes
Sep 20, 2022
added 2 commits
September 20, 2022 10:04
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the change of
TestAccVcdOrgGroupin PR-909The reason for this change is that what we are testing within TestLDAP is quite fast, but the preparation takes a long time, so much that we added a tag
skipLongto avoid such test in given circumstances. Moreover, creating a LDAP server (which requires routing to the VM) would fail for environmental reasons that add nothing to our testing experience.The change requires a pre-set LDAP server, which is created only once per each VCD in a separate –automated– task, thus allowing us to test the intended feature without waiting for the server to be up.