Adjust VM code #509
Merged
Adjust VM code #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
This reverts commit 7c82bc7.
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
commented
Oct 12, 2022
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
lvirbalas
approved these changes
Oct 13, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
approved these changes
Oct 18, 2022
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has a few tweaks for existing VM code.
vApp.AddRawVMto support addition of VM from type*types.ReComposeVAppParamsinstead of functions such asAddNewVMWithComputePolicy,AddNewVMWithStorageProfile,AddNewVMwhich only accept some field values and need constant improvement.vm.ChangeCPUAndCoreCountwhich is almost the same asvm.ChangeCPUexcept that it accepts pointers instead of integers - this gives the option to specify only one of values the other being nil, which is more convenient in some workflows (including terraform-provider-vcd)types.RecomposeVAppParamsForEmptyVmhad missingPowerOnfield which is used to control VM power state on creationAdditional. Apparently we had a long existing inverse action for testing flag
GOVCD_IGNORE_CLEANUP_FILE. It would perform cleanup for previous files only ifGOVCD_IGNORE_CLEANUP_FILEis set (which is the reverse of its meaning). This PR patches condition check to match name of the flag.