-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust VM Placement Policy code #513
Adjust VM Placement Policy code #513
Conversation
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into adjust-placement-policy-code Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass one - it is all clear, except I have this one query about possibly problems with vGpu policies (you will find it in comments)
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Test passed on 10.3.3, 10.4..0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor issue. LGTM otherwise
Overview
This PR adds a new method to update Compute Policies in VMs with the v2.0.0 version of the API, that also adds support for VM Placement Policies.
It sets the foundations for vmware/terraform-provider-vcd#922, as in this PR we onboard VM Placement Policies for VMs.