Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust VM Placement Policy code #513

Merged
merged 18 commits into from
Nov 16, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Oct 25, 2022

Overview

This PR adds a new method to update Compute Policies in VMs with the v2.0.0 version of the API, that also adds support for VM Placement Policies.

It sets the foundations for vmware/terraform-provider-vcd#922, as in this PR we onboard VM Placement Policies for VMs.

abarreiro added 2 commits October 25, 2022 12:33
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 4 commits October 25, 2022 16:47
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into adjust-placement-policy-code

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
abarreiro added 3 commits November 7, 2022 16:22
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this Nov 8, 2022
@adambarreiro adambarreiro marked this pull request as ready for review November 8, 2022 10:11
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass one - it is all clear, except I have this one query about possibly problems with vGpu policies (you will find it in comments)

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Test passed on 10.3.3, 10.4..0

abarreiro added 3 commits November 14, 2022 15:53
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into adjust-placement-policy-code

Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into adjust-placement-policy-code

Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor issue. LGTM otherwise

abarreiro added 3 commits November 15, 2022 09:14
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into adjust-placement-policy-code

Signed-off-by: abarreiro <abarreiro@vmware.com>
…ctor into adjust-placement-policy-code

Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit 7023d30 into vmware:main Nov 16, 2022
@adambarreiro adambarreiro deleted the adjust-placement-policy-code branch November 16, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants