Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to run gosec and amend already present issues #516

Merged
merged 15 commits into from
Nov 4, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Nov 2, 2022

Description

This PR is not related to any opened issue as far as I know. It adds the gosec tool as a GitHub Action that runs on every push and pull_request event.

As we had already some issues detected in the code, adding this action would break all subsequent PR builds, hence no one could merge until solved. For that reason, this PR also solves/amends the found issues.

Thanks @dataclouder for the gosec idea!

  • Tests pass

abarreiro added 5 commits November 2, 2022 15:07
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review November 2, 2022 14:24
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few possible improvements. Let's discuss

abarreiro added 9 commits November 2, 2022 16:29
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am good provided this runs well

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adambarreiro adambarreiro merged commit 1c40dcf into vmware:main Nov 4, 2022
@adambarreiro adambarreiro deleted the add-gosec-and-fix-issues branch November 4, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants