Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TestMediaRecordMetadata cleanup #522

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Improve TestMediaRecordMetadata cleanup #522

merged 1 commit into from
Nov 24, 2022

Conversation

Didainius
Copy link
Collaborator

  • TestMediaRecordMetadata created a media image for usage within tests, but did not remove it at the end of tests (only added it to cleanup list). As a result test Test_CatalogQueryMediaList failed because it assumes media count
catalog_test.go:1028:
    check.Assert(len(medias), Equals, 1)
... obtained int = 2
... expected int = 1

@Didainius
Fix TestMediaRecordMetadata
56d1613 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review November 24, 2022 08:21
@Didainius Didainius changed the title Cleanup test errors Improve TestMediaRecordMetadata cleanup Nov 24, 2022
@Didainius Didainius removed the request for review from lvirbalas November 24, 2022 08:59
@Didainius Didainius merged commit 10f3e08 into vmware:main Nov 24, 2022
@Didainius Didainius deleted the test-fixes branch November 24, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@dataclouder dataclouder dataclouder approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Didainius @adambarreiro @dataclouder @vmwclabot