Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change position of BackLinkIdentifier in LDAP type #533

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Dec 9, 2022

The position of the field was wrong, and prevented update when that field was set.

To test:

go test -tags functional -check.f Test_LDAP -check.vv -timeout 0

The position was wrong, and preventing update when that field was set

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder marked this pull request as ready for review December 9, 2022 18:44
@dataclouder dataclouder self-assigned this Dec 9, 2022
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@dataclouder dataclouder merged commit d2e5b6c into vmware:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants