Adjust vet and gosec complaints #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2023 20:40
Fix complaints for test files that were previously unchecked Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius and
adambarreiro
as code owners
adambarreiro
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
make vetwas running without tags, and therefore it was ignoring most of the test files.After adding
-tags ALL, some complains appeared that are addressed here.Makefilegovcd/access_control_catalog_test.gogovcd/access_control_vapp_test.gogovcd/catalog_test.gogovcd/common_test.gogovcd/external_network_v2_test.gogovcd/nsxt_firewall_group_dynamic_security_group_test.goThe latest version of
gosec(2.15 released today) raises several security complaints related to unsafe usage ofdefer. Such usages are fixed in this PR.govcd/api_vcd.gogovcd/catalog.gogovcd/media.gogovcd/nsxt_importable_switch.goFurthermore, the installation of
gosecin the Github Actions worker sometimes fails with unclear errors. To help understanding the issue, we have added more debugging information toscripts/gosec.sh.