NSX-T Edge Gateway QoS (rate limiting) support #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
adezxc
reviewed
Apr 6, 2023
adezxc
approved these changes
Apr 6, 2023
lvirbalas
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #472
This PR adds two things:
GetAllNsxtEdgeGatewayQosProfilesandGetNsxtEdgeGatewayQosProfileByDisplayNameNsxtEdgeGateway.GetQoSandNsxtEdgeGateway.UpdateQoSNote. This feature is supported on VCD 10.3.2+ and
Testing
Testing requires Gateway QoS profiles pre-created in NSX-T manager therefore there is a new
GatewayQosProfilefield inTestConfigstruct.