-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NSX-T Edge Gateway External Uplink configuration #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
559b662
to
d59fe9e
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
d59fe9e
to
4a77390
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
…10.4.0 Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
reviewed
Aug 31, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
reviewed
Sep 5, 2023
adambarreiro
approved these changes
Sep 5, 2023
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
adezxc
approved these changes
Sep 26, 2023
dataclouder
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing pieces to support NSX-T Edge Gateway External Network uplinks (only for external networks backed by NSX-T Segments) (VCD 10.4.1+)
List of things added:
*NsxtEdgeGateway.reorderUplinks()
that will order NSX-T Edge Gateway uplinks. There are two major types of uplinksNSXT_TIER0
orNSXT_VRF_TIER0
- Tier 0 gateway backed external network (mandatory and is required during creation)IMPORTED_T_LOGICAL_SWITCH
NSX-T segment backed external network (this is optional, attached post creation in "External networks" tab)NsxtEdgeGateway.GetAllocatedIpCountByUplinkType
complementing existingNsxtEdgeGateway.GetAllocatedIpCount
. It will return allocated IP counts by uplink types (requires VCD 10.4.1+)NsxtEdgeGateway.GetPrimaryNetworkAllocatedIpCount
that will return total allocated IPcount for primary uplink (T0 or T0 VRF)
types.EdgeGatewayUplinks.BackingType
that defines backing type of NSX-T Edge GatewayUplink (available in VCD 10.4.1+)
Note on uplink ordering. API usually returns the mandatory network as element 0 in the resulting slice, but there have been cases where VCD sometimes shuffles these responses (don't have a proof for this particular endpoint). As a result - the
reorderUplinks
function is here to ensure thatNSXT_TIER0
orNSXT_VRF_TIER0
uplink is always at position 0. It is also used in all functions related to NSX-T Edge Gateway.Tested with tags
nsxt gateway network
:Tests are for admin mode only, skip directive for Org tests is in place. The test requires 10.4.1+.