Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add segment profile template support #618

Merged
merged 30 commits into from
Nov 7, 2023
Merged

Add segment profile template support #618

merged 30 commits into from
Nov 7, 2023

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Sep 18, 2023 •
edited
Loading

This PR adds code relevant for Segment Profile Template creation and usage throughout VCD.
There are more details about using it in vmware/terraform-provider-vcd#1120

https://docs.vmware.com/en/VMware-NSX/4.1/administration/GUID-93112326-FE2F-4521-9282-505FF67DDC23.html

@Didainius
Add segment profile template retrieval and configuration
46708f2 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Imrovements
3baf4f4 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Merge branch 'main' into nsxt-segment-profile-templates
1b0e89e
@Didainius
Progress
8a7d5fd
@Didainius
WIP
8b52f75 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Shuffle types, improve documentation
1677302 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
WIP
cbb624e 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
WIP
3473bd8 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Improve generic functions
d892e91 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Self review
6fc82d8 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Self review 2
12df4f7 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Restructure, add changelog
34abafb 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Shuffle types
dfa7d8d 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Self review
c4cf73f 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review October 4, 2023 08:25
@Didainius
Patch NsxtGlobalDefaultSegmentProfileTemplate cleanup to reflect corr…
d0cd7e1 
…ect status

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
dataclouder reviewed Oct 8, 2023
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass

@Didainius
Address comments
2091b4a 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Convert NsxtManager.Urn to function
bb6a1ac 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Use struct config for generic functions
762dffa 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Improve docs
83674d0 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Revert "Improve docs"
0870b43 
This reverts commit 83674d0.
@Didainius
Revert "Use struct config for generic functions"
071eb74 
This reverts commit 762dffa.
@Didainius
Simplify
32d9146 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Remove comment
afb822b 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Fix incorrect replacements
c507228 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as draft October 11, 2023 09:32
@Didainius
Use original OpenAPI functions
0063a02 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Cleanup incorect comments
33639b3 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review October 11, 2023 12:12
adezxc
adezxc approved these changes Oct 11, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot to handle with all the new variable names and contexts, but it's a nice feature, thanks!

lvirbalas
lvirbalas approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

adambarreiro
adambarreiro reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few doubts/nits

@Didainius
Address comments
33364a7 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 598ca18 into vmware:main Nov 7, 2023
@Didainius Didainius deleted the nsxt-segment-profile-templates branch November 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

@adezxc adezxc adezxc approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Didainius @adambarreiro @lvirbalas @dataclouder @adezxc @vmwclabot