Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSX-T Edgegateway L2 VPN Tunnel session management #619

Merged
merged 22 commits into from
Oct 16, 2023
Merged

NSX-T Edgegateway L2 VPN Tunnel session management #619

merged 22 commits into from
Oct 16, 2023

Conversation

adezxc
Copy link

@adezxc adezxc commented Sep 28, 2023 •
edited
Loading

This PR adds support for L2 VPN Tunnel sessions

  • Added new methods for NsxtEdgeGateway: CreateL2VpnTunnel, GetAllL2VpnTunnels, GetL2VpnTunnelByName, GetL2VpnTunnelById
  • Added new types types.EdgeL2VpnStretchedNetwork, types.EdgeL2VpnTunnelStatistics, types.EdgeL2VpnTunnelStatus.
  • Add new type NsxtL2VpnTunnel and its methods: Refresh, Update, Statistics, Status, Delete

Place in UI

image

Adam Jasinski added 12 commits September 11, 2023 12:36
Create NsxtL2VpnTunnel type
645f2c0 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Create nsxt_edgegateway_l2_vpn.go file and create simple GET call
f8919e8 
function

Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Fix GetAllL2VpnTunnels, create a test for it, add more comments about
a24774c 
the type

Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Add methods for creation and getting by id
77c685e 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Update to CreateVmTunnel test
3b027f3 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
add Delete() method
8fc827b 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Add Refresh(), Update(), Statistics(), Status() methods, update tests
555a6da 
so it also tries to create a CLIENT type tunnel

Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Add unexpected error handling
0d89576 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
merge main
3504e13 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
update endpoint version, more comment fixes
2ad096a 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Add comments regarding known bugs with CLIENT sessions
406af5f 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
fix tests
106975c 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc mentioned this pull request Sep 28, 2023
Merged
add changelog entry
6ff708d 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
lvirbalas
lvirbalas approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the test! :)

adambarreiro
adambarreiro reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing feature, it is really nice to have the comments describing the current quirks, they make the whole thing more understandable.
I'll run the tests and approve afterwards, just sharing few little things I found and some doubts.

adambarreiro
adambarreiro approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed for me on VCD 10.5.0

dataclouder
dataclouder reviewed Oct 2, 2023
View reviewed changes
Adam Jasinski added 3 commits October 2, 2023 12:15
address comments
78fff13 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
add refresh() comment
45eb234 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
remove apostrophe
4a0effb 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc requested a review from dataclouder October 2, 2023 09:20
Didainius
Didainius requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - a few queries from me

Adam Jasinski added 2 commits October 8, 2023 21:08
Address comments: add non-sysadmin check, fix version constraints for
f121a13 
bugs, and use queryParameterFilterAnd for filtering by name

Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
remove filter by name, update test to check that it returns it succes…
734ae3a 
…sfully

Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Adam Jasinski added 2 commits October 9, 2023 18:19
Check if there are tunnels with the same name, return an error if so
d5859b9 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Fix getting by name
493c8cf 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Adam Jasinski added 2 commits October 10, 2023 09:52
merge main
6d622ea 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
Extend error message
340dfac 
Signed-off-by: Adam Jasinski <jasinskia@vmware.com>
@adezxc adezxc merged commit b2826f9 into vmware:main Oct 16, 2023
@adezxc adezxc deleted the edgegateway_l2_vpn branch October 16, 2023 10:47
@adezxc adezxc mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

@dataclouder dataclouder dataclouder approved these changes

@Didainius Didainius Didainius approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adezxc @adambarreiro @lvirbalas @dataclouder @Didainius @vmwclabot