Amend metadata tests to be compatible with latest VCD #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
changed the title
lvirbalas
approved these changes
Nov 14, 2023
adambarreiro
requested review from
Didainius,
dataclouder and
adezxc
as code owners
added 2 commits
November 14, 2023 15:30
Signed-off-by: abarreiro <abarreiro@vmware.com>
dataclouder
approved these changes
Nov 15, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
approved these changes
Nov 16, 2023
adezxc
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest VCD version, certain items such as vApps and VMs that are created via a vApp Template come with autogenerated metadata that needs to be considered.
In the metadata tests, there was an assert that expected a hardcoded value of 2, but this number may vary due to the reason stated above, or due to any other feature that may come in the future. In order to make the test more robust and flexible, instead of hardcoding we use a real calculated value that varies depending on the case.
This also fixes the cleanup function, that was removing all metadata, instead of respecting the already existent metadata.
go test -tags metadata -check.vv -timeout 0go test -tags metadata -check.vv -timeout 0