Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UDF file format reader to support solutions add-on installation #647

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

vmanasiev
Copy link
Contributor

@vmanasiev vmanasiev commented Jan 30, 2024

Short Description

An internal package to support installation of VCD Solution Add-ons

Description

In this package a reader is implemented that supports extracting files from solutions add-on ISO without unpacking/mounting it advance.

Motivation

A new feature is being implemented where the vcd client and terraform provider should support installation of the VCD solution add-ons. Solution add-ons are packaged as an ISO media. To support larger files and avoid other issues with simple CDROM file format, the .iso file is packaged as UDF filesystem (specification: http://www.osta.org/specs/pdf/udf260.pdf ).
udf internal package implements partially that specification and enables read. Specifically, the code allows only reading of top level objects within a .ISO file.

Signed-off-by: Valentin Manasiev <vmanasiev@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Approving in advance with a few requests below:

@vmanasiev or @dataclouder please add a few things:

  1. Amend the PR description to state that this code is extracting only files from the top of the ISO tree.
  2. Add top-level comment/description to the .go files (which are missing it) to explain the purpose and expectations of the code of a particular file.

@dataclouder
Copy link
Contributor

Thank you for your contribution. Approving in advance with a few requests below:

@vmanasiev or @dataclouder please add a few things:

1. Amend the PR description to state that this code is extracting only files from the top of the ISO tree.

2. Add top-level comment/description to the .go files (which are missing it) to explain the purpose and expectations of the code of a particular file.

I will take care of the code description after merging.

@dataclouder dataclouder merged commit c645ba1 into vmware:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants