Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP Space floating IP suggestion method #648

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Add IP Space floating IP suggestion method #648

merged 7 commits into from
Feb 8, 2024

Conversation

Didainius
Copy link
Collaborator

This PR adds *VCDClient.GetAllIpSpaceFloatingIpSuggestions method as well as relevant type IpSpaceFloatingIpSuggestion

@Didainius
WIP
2eecce6 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Floating IP suggestions
265d5e7 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Self review
a996b97 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Add changelog
e7be021 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius requested a review from rocknes February 1, 2024 11:52
@Didainius Didainius changed the title Add IP Space floating IP suggestion function Add IP Space floating IP suggestion method Feb 1, 2024
rocknes
rocknes approved these changes Feb 6, 2024
View reviewed changes
Copy link

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Didainius
Extract gatewayId to explicit argument as it is mandatory
27b17b5 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius
Extract gatewayId to explicit argument as it is mandatory
dc4d84f 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review February 6, 2024 19:36
lvirbalas
lvirbalas approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ask and looks great!

@Didainius
Address comment
08140c4 
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
adambarreiro approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Didainius Didainius merged commit 3e493d6 into vmware:main Feb 8, 2024
2 checks passed
@Didainius Didainius deleted the floating-ip-suggestions branch February 8, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@rocknes rocknes rocknes approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Didainius @adambarreiro @rocknes @lvirbalas @dataclouder @vmwclabot