Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vm.ConsolidateDisks and vm.ConsolidateDisksAsync #650

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Feb 8, 2024

This PR adds support for VM disk consolidation vm.ConsolidateDisks and vm.ConsolidateDisksAsync that is required for Terraform vmware/terraform-provider-vcd#1206

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review February 12, 2024 04:47
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test too!

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Test passed for me on 10.5.1

@Didainius Didainius merged commit 2e4e75f into vmware:main Feb 22, 2024
2 checks passed
@Didainius Didainius deleted the consolidate-disks branch February 22, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants