-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TM Provider Gateway #725
Merged
Merged
TM Provider Gateway #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
regional-networking-2
branch
from
December 4, 2024 14:11
eec9d31
to
08e00d0
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
adambarreiro
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Test passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds needed components for managing TM Provider Gateways:
TmProviderGateway
andtypes.TmProviderGateway
structures and methodsVCDClient.CreateTmProviderGateway
,VCDClient.GetAllTmProviderGateways
,VCDClient.GetTmProviderGatewayByName
,VCDClient.GetTmProviderGatewayById
,VCDClient.GetTmProviderGatewayByNameAndRegionId
,TmProviderGateway.Update
,TmProviderGateway.Delete
to manage Provider GatewaysTmTier0Gateway
andtypes.TmTier0Gateway
structures consumption and methodsVCDClient.GetAllTmTier0GatewaysWithContext
,VCDClient.GetTmTier0GatewayWithContextByName
toread Tier 0 Gateways that are available for TM consumption
TmIpSpaceAssociation
andtypes.TmIpSpaceAssociation
structures and methodsVCDClient.CreateTmIpSpaceAssociation
,VCDClient.GetAllTmIpSpaceAssociations
,VCDClient.GetTmIpSpaceAssociationById
,VCDClient.GetAllTmIpSpaceAssociationsByProviderGatewayId
,VCDClient.GetAllTmIpSpaceAssociationsByIpSpaceId
,TmIpSpaceAssociation.Delete
to manage IPSpace associations with Provider Gateways
Note. Testing of all these components is concentrated in
Test_TmProviderGateway
because everything is related and doesn't make much sense in isolation.