Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM Provider Gateway #725

Merged
merged 27 commits into from
Dec 20, 2024
Merged

TM Provider Gateway #725

merged 27 commits into from
Dec 20, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Dec 4, 2024

This PR adds needed components for managing TM Provider Gateways:

  • Added TmProviderGateway and types.TmProviderGateway structures and methods
    VCDClient.CreateTmProviderGateway, VCDClient.GetAllTmProviderGateways,
    VCDClient.GetTmProviderGatewayByName, VCDClient.GetTmProviderGatewayById,
    VCDClient.GetTmProviderGatewayByNameAndRegionId, TmProviderGateway.Update,
    TmProviderGateway.Delete to manage Provider Gateways
  • Added TmTier0Gateway and types.TmTier0Gateway structures consumption and methods
    VCDClient.GetAllTmTier0GatewaysWithContext, VCDClient.GetTmTier0GatewayWithContextByName to
    read Tier 0 Gateways that are available for TM consumption
  • Added TmIpSpaceAssociation and types.TmIpSpaceAssociation structures and methods
    VCDClient.CreateTmIpSpaceAssociation, VCDClient.GetAllTmIpSpaceAssociations,
    VCDClient.GetTmIpSpaceAssociationById,
    VCDClient.GetAllTmIpSpaceAssociationsByProviderGatewayId,
    VCDClient.GetAllTmIpSpaceAssociationsByIpSpaceId, TmIpSpaceAssociation.Delete to manage IP
    Space associations with Provider Gateways

Note. Testing of all these components is concentrated in Test_TmProviderGateway because everything is related and doesn't make much sense in isolation.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius force-pushed the regional-networking-2 branch from eec9d31 to 08e00d0 Compare December 4, 2024 14:11
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review December 13, 2024 12:52
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Test passed

@Didainius Didainius merged commit 05b2e43 into vmware:main Dec 20, 2024
2 checks passed
@Didainius Didainius deleted the regional-networking-2 branch December 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants