Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fields.info not camelCase #3243

Closed
xarem opened this issue Sep 27, 2023 · 0 comments · Fixed by #3247
Closed

[BUG] fields.info not camelCase #3243

xarem opened this issue Sep 27, 2023 · 0 comments · Fixed by #3247

Comments

@xarem
Copy link
Contributor

xarem commented Sep 27, 2023

Describe the bug

Similar to #3241

fields.info is still PascalCase

To Reproduce

vcsim -api-version 8.0 -dc 0 -l :8989 &
export GOVC_URL=https://user:pass@172.17.0.2:8989/sdk GOVC_SIM_PID=10
export GOVC_INSECURE=true

govc fields.add -type=Folder folder-test
govc datacenter.create test-dc
govc cluster.create test-cluster
govc cluster.add -hostname test-host -username user -password pass -noverify
govc datastore.create -type local -name test-ds -path /tmp 'test-cluster/*'
govc vm.create -net="VM Network" -m=4096 -c=1 -g=ubuntu -disk=40G -folder=/test-dc/vm test-vm
govc fields.set folder-test "Hello world" /test-dc/vm/test-vm
govc fields.info -json /test-dc/vm/test-vm

Result

{
  "Info": [
    {
      "Object": {
        "type": "VirtualMachine",
        "value": "vm-22"
      },
      "Path": "/test-dc/vm/test-vm",
      "Name": "test-vm",
      "Key": "folder-test",
      "Value": "Hello world"
    }
  ]
}

Expected behavior

{
  "info": [
    {
      "object": {
        "type": "VirtualMachine",
        "value": "vm-22"
      },
      "path": "/test-dc/vm/test-vm",
      "name": "test-vm",
      "key": "folder-test",
      "value": "Hello world"
    }
  ]
}

Affected version

v0.31.0

dougm added a commit to dougm/govmomi that referenced this issue Sep 27, 2023
PR vmware#3007 added camelCase json tags for generated types
BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types

Fixes vmware#3243
Fixes vmware#3242
Fixes vmware#3241
dougm added a commit to dougm/govmomi that referenced this issue Sep 27, 2023
PR vmware#3007 added camelCase json tags for generated types
BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types

Fixes vmware#3243
Fixes vmware#3242
Fixes vmware#3241
dougm added a commit to dougm/govmomi that referenced this issue Sep 27, 2023
PR vmware#3007 added camelCase json tags for generated types
BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types

Fixes vmware#3243
Fixes vmware#3242
Fixes vmware#3241
priyanka19-98 pushed a commit to priyanka19-98/govmomi that referenced this issue Jan 17, 2024
PR vmware#3007 added camelCase json tags for generated types
BREAKING: This change adds camelCase (lower-case 1st character) json tags for govc types

Fixes vmware#3243
Fixes vmware#3242
Fixes vmware#3241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant