Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update #3286

Closed
jsvoboda-prgs opened this issue Nov 13, 2023 · 4 comments
Closed

Changelog update #3286

jsvoboda-prgs opened this issue Nov 13, 2023 · 4 comments

Comments

@jsvoboda-prgs
Copy link

Is your feature request related to a problem? Please describe.
Changelog is outdated. Last update was a year ago, for govc version 0.30.
There were several important commits after that, for example #3247
which introduced a breaking change in JSON output from govc.

I didn't find any other place than CHANGELOG.md where release notes and breaking changes are announced.
Has the changelog moved to a different location?

Thank you.

Copy link
Contributor

Howdy 🖐   jsvoboda-prgs ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

@dougm
Copy link
Member

dougm commented Dec 13, 2023

Hi @jsvoboda-prgs , hadn't noticed that until you raised this. I've only been looking at generated release notes: https://github.com/vmware/govmomi/releases

We must have broken CHANGELOG generation (happens during release) somewhere in the GitHub actions code (which I don't know well), but will try to look before the next release.

dougm added a commit to dougm/govmomi that referenced this issue Mar 7, 2024
CHANGELOG update is supposed to be automatic, see issue vmware#3286
@dougm
Copy link
Member

dougm commented Mar 7, 2024

Haven't had time to figure out the GH Actions auto-magic, updated manually for now using:

IMAGE=quay.io/git-chglog/git-chglog IMAGE_SHA=998e89dab8dd8284cfff5f8cfb9e9af41fe3fcd4671f2e86a180e453c20959e3 \
  docker run --rm -v $PWD:/workdir ${IMAGE}@sha256:${IMAGE_SHA} -o CHANGELOG.md --sort semver --tag-filter-pattern '^v[0-9]+' -t .chglog/CHANGELOG.tpl.md

@jsvoboda-prgs
Copy link
Author

Thank you. :-)

dougm added a commit to dougm/govmomi that referenced this issue Oct 2, 2024
Incoming fix for release automation updates (see vmware#3286)
dougm added a commit to dougm/govmomi that referenced this issue Oct 2, 2024
Incoming fix for release automation updates (see vmware#3286)
dougm added a commit to dougm/govmomi that referenced this issue Oct 3, 2024
Incoming fix for release automation updates (see vmware#3286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants