Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call DestroyCollector when event processing comletes #961

Closed
hickeng opened this issue Dec 13, 2017 · 0 comments
Closed

Call DestroyCollector when event processing comletes #961

hickeng opened this issue Dec 13, 2017 · 0 comments

Comments

@hickeng
Copy link
Member

hickeng commented Dec 13, 2017

There is a convenience method events.Manager.Events which constructs one or more EventHistoryCollectors and uses them to provide an event stream.

Currently there is no way to access those collectors and there is no logic to delete them when the stream completes as per http://pubs.vmware.com/vsphere-6-0/topic/com.vmware.wssdk.apiref.doc/vim.HistoryCollector.html#remove

They are lifecycle coupled to the session so will eventually be deleted, but currently are left dangling. Ideally these would be deleted either by an explicit call on the manager, or along with the List views when the event processor exits.
@dougm dougm mentioned this issue Dec 13, 2017
Closed
dougm added a commit to dougm/govmomi that referenced this issue Dec 13, 2017
@dougm
Destroy event history collectors
4fb5034 
The EventHistoryCollector objects are tied to a session and there is a max per-session.
Without destroying the collectors, we could max out the collectors causing 'govc events' to return empty.

Fixes vmware#948
Fixes vmware#961
@dougm dougm mentioned this issue Dec 13, 2017
Merged
dougm added a commit to dougm/govmomi that referenced this issue Dec 13, 2017
@dougm
Destroy event history collectors
475fd8f 
The EventHistoryCollector objects are tied to a session and there is a max per-session.
Without destroying the collectors, we could max out the collectors causing 'govc events' to return empty.

Fixes vmware#948
Fixes vmware#961
dougm added a commit that referenced this issue Dec 13, 2017
@dougm
Destroy event history collectors (#962)
aef2d79 
The EventHistoryCollector objects are tied to a session and there is a max per-session.
Without destroying the collectors, we could max out the collectors causing 'govc events' to return empty.

Fixes #948
Fixes #961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hickeng