-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc #231
Misc #231
Conversation
5422094
to
fb0033d
Compare
This function uses CreateFilter to be selective in the updates it receives. Filters can only be added to property collectors, not removed. This means that a property collector is no longer useful after being used by Wait. This in turn means that it is most convenient to have Wait create and destroy a property collector for its own use.
Awesome @pietern , looks great! btw, feel free to remove '_gen' from the filenames, we can revisit that if we get a decent wrapper generator working. |
@mkuzmin As a heads up, once this PR is merged it will break downstream code. Wiring context.Context into the entire library was prompted by both your WaitForIP timeout problems and some code I had written that needed timeout management. Now that everything is wired up, every in flight chain of requests can be cancelled outside-in at any time. Through context.Context it is trivial to add timeouts to sequences of requests. |
These files were automatically generated, but have been edited since.
This PR is a bag of stuff I came across while moving functionality out of the root package into independent subpackages and moving all code to use a context.Context to make it easy to control client side timeouts on arbitrary sequences of requests. See: http://godoc.org/golang.org/x/net/context
Including:
url.URL
as value instead of pointer value (unnatural if you look at the stdlib)*soap.Client
in root clientsoap.RoundTripper
tosession
package (cc @hickeng)task
packageobject
packageproperty
package