fix: share http.Transport with service clients #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brakthehack
reviewed
Jun 27, 2023
brakthehack
previously approved these changes
Jun 27, 2023
brakthehack
reviewed
Jun 27, 2023
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Jun 28, 2023
PR vmware#3161 introduced a race when sharing http transport between soap client and service clients
priyanka19-98
pushed a commit
to priyanka19-98/govmomi
that referenced
this pull request
Jan 17, 2024
PR vmware#3161 introduced a race when sharing http transport between soap client and service clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3039