fix: lookup client to use envoy sidecar url if enabled

[ramineni]

currently, lookup client by default fetches the uri from "config.vpxd.sso.sts.uri" value if service content set . With envoy sidecar enabled, this MR is to first check for envoy sidecar url if present and use the same.

[ramineni]

cc @mayankbh

[dougm]

Thanks @ramineni . Can you fixup the commit message to include a fix: prefix? This is for the ChangeLog generator, see: https://github.com/vmware/govmomi/blob/main/CONTRIBUTING.md#format-of-the-commit-message

The Scheme and Host will default to those values when empty, see:

govmomi/vim25/soap/client.go

Lines 206 to 209 in e4c027e

	if u.Host == "" {
	u.Scheme = vc.Scheme
	u.Host = vc.Host
	}

So just the following (untested) change below should work:

@@ -57,7 +58,7 @@ type Client struct {
 func NewClient(ctx context.Context, c *vim25.Client) (*Client, error) {
 	// PSC may be external, attempt to derive from sts.uri
 	path := &url.URL{Path: Path}
-	if c.ServiceContent.Setting != nil {
+	if !internal.UsingEnvoySidecar(c) && c.ServiceContent.Setting != nil {
 		m := object.NewOptionManager(c, *c.ServiceContent.Setting)
 		opts, err := m.Query(ctx, "config.vpxd.sso.sts.uri")
 		if err == nil && len(opts) == 1 {

[ramineni]

@dougm Thanks for the review. you are right. Fixed it. Thanks.

[dougm]

Thanks @ramineni