Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

govc: Add '-size' flag to datastore.create #3534

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

HaruChebrolu
Copy link
Contributor

@HaruChebrolu HaruChebrolu commented Aug 29, 2024

Closes: #3519

Description

govc: Add support for providing size while we create a VMFS datastore

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Test Description 1
    Tried to create a VMFS datastore without size argument in govc cli, so that it takes the entire size of disk into consideration(default case)
    go run main.go datastore.create -type VMFS -name vmfs61 -version 6 -disk eui.b8fa2f975ecc490ea090a46404568540 ocsqe-virt07.lab.eng.blr.redhat.com
  • Test Description 2
    Tried to create a VMFS datastore with some size in govc cli
    go run main.go datastore.create -type VMFS -name vmfs61 -version 6 -disk eui.b8fa2f975ecc490ea090a46404568540 -size 30 ocsqe-virt07.lab.eng.blr.redhat.com

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@HaruChebrolu
Copy link
Contributor Author

@dougm I've been attempting to run make doc multiple times after rebasing, but each time I encounter the same error from the GitHub action. I've also tried running ./usage.sh > USAGE.md directly, but the error persists. Could you please assist me in resolving this issue?

Closed #3528, as I thought that there was some issue with my previous branch.

@dougm
Copy link
Member

dougm commented Aug 29, 2024

@dougm I've been attempting to run make doc multiple times after rebasing, but each time I encounter the same error from the GitHub action. I've also tried running ./usage.sh > USAGE.md directly, but the error persists. Could you please assist me in resolving this issue?

Hi @HaruChebrolu , you just need to rebase with latest vmware/govmomi main since a new govc command has been added. Then run make doc again

@dougm
Copy link
Member

dougm commented Aug 29, 2024

@HaruChebrolu , not sure what you did, but now there are 6 commits.. I'm going to fix it and force push to your branch

@dougm dougm force-pushed the datastore_size branch 2 times, most recently from e226441 to 2a1cf41 Compare August 29, 2024 18:56
Closes: vmware#3519
Signed-off-by: Chebrolu <hchebrol@redhat.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaruChebrolu , lgtm

@dougm dougm merged commit 7be6ec9 into vmware:main Aug 29, 2024
10 checks passed
@vmwclabot
Copy link
Member

@HaruChebrolu, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] How to provide a size when creating a datastore
3 participants