Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcsim: add DatastoreNamespaceManager Create/Delete directory methods #3670

Merged
merged 1 commit into from
Jan 7, 2025
Merged

vcsim: add DatastoreNamespaceManager Create/Delete directory methods #3670

merged 1 commit into from
Jan 7, 2025

Conversation

dougm
Copy link
Member

@dougm dougm commented Jan 6, 2025

No description provided.

@dougm
vcsim: add DatastoreNamespaceManager Create/Delete directory methods
f02e7e9 
Signed-off-by: Doug MacEachern <dougm@broadcom.com>
@dougm dougm requested a review from akutz January 6, 2025 19:33
luisdavim
luisdavim approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akutz
akutz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm @dougm , thanks, but should it not simulate the UUID as the underlying dir name and use the Convert call to get back the UUID from a friendly name later?

@dougm
Copy link
Member Author

dougm commented Jan 7, 2025

Lgtm @dougm , thanks, but should it not simulate the UUID as the underlying dir name and use the Convert call to get back the UUID from a friendly name later?

Will follow up on this in a separate PR

@dougm dougm merged commit 8f7d233 into vmware:main Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdavim luisdavim luisdavim approved these changes

@akutz akutz akutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougm @akutz @luisdavim