Click the "DEPLOY" button directly will fail if the repository contain no image whose tag is latest

[ywk253100]

If the repository library/hello-world contains no image whose tag is latest, clicking the DEPLOY buttion will fail as the latest is the default value if no tag is specified:

Users can click the Add addtional info and choose an existing tag to work around this issue:

[lweitzman]

we should follow the clarity standards and have the main action "Deploy" along with the menu "Actions v". in the menu we should have "Deploy with options" and a dividing line and "Delete"
when there are no images with the "latest" tag, then the Deploy button should be grayed out and not removed. see https://vmware.invisionapp.com/share/ZVF75AZAW#/271907734_Projects_-_Repositories_-_Card_V1-4
where you can click on the menu for the wordpress repo.

issue #4787 is related

[steven-zou]

@lweitzman The button style should be kept consistent with the button in Admiral side

[ninjadq]

@lweitzman I agree with you, but Admiral does not strictly obey the clarity standard. Most of the engineering work of your design is on Admiral side. But currently, we should follow their style, or can you persuade them?

[lweitzman]

@ninjadq asking PM and eng leads about consistency of menus with the hope that i can persuade them

[reasonerjt]

Before we reach agreement with Admiral.
On Harbor's UI we can mitigate the issue by:
When there's no "latest" tag of the repo, the deploy button will be disabled and a tooltip will be shown to ask user set the "additional info"

[lweitzman]

Instead of "additional info" i recommend that we rename that option to "Deploy with options" as stated above. I think its much clearer as to what the action is going to do.

[stuclem]

Proposed release note:

• Clicking Deploy for an image in the Internal Repositories view fails if no latest tag is present. #4788This will be fixed in an update release.

@reasonerjt is this OK?

[reasonerjt]

We'll use this issue to track the text change, will close it once we confirm the text in the label and make necessary change.