Multiple fixes and cleanup for FreeBSD #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oldest supported FreeBSD version is 12.3. Remove code added to implement support for older versions. No functional changes.
On FreeBSD a SIGBUS is delivered when accessing port that is not accessible, which is the case when running vmware-vmcheck on bare metal system.
Recently NDF_ONLY_PNBUF was removed from FreeBSD code. NDFREE_PNBUF should be used instead.
After FreeBSD OSVERSION 1400051, insmntque1() was changed and only have 2 parameters. This commit fixes the build.
After FreeBSD OSVERSION 1400043, NDINIT() last parameter was removed.
|
@rbgarga, VMware has approved your signed contributor license agreement. |
|
@johnwvmw can you check this out when you have some time? It would be nice to reduce technical debt on FreeBSD ports |
fkaty
added a commit
that referenced
this pull request
Jan 18, 2023
Changes to allow open-vm-tools and drivers to be compiled for newer FreeBSD releases and clean-up/remove code for earlier FreeBSD releases that are no longer supported by the FreeBSD Foundation. - remove old FreeBSD version support. - trap SIGBUS while VmCheckSafe(). - fix build on recent versions. - fix build after 1400043 - fix build after 1400051. - replace deprecated NO_MAN by MK_MAN=no. Pull request: #584
|
@johnwvmw This one can be closed now |
|
Thanks, Renato |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD ports tree we have multiple patches [1] to get open-vm-tools working on all supported versions. The main idea of this PR is to upstream some of those patches.
While here I decided to also cleanup code that was added to support old FreeBSD versions. The older supported version is 12.3.
[1] https://github.com/freebsd/freebsd-ports/tree/main/emulators/open-vm-tools/files