Packer/Vagrant updates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added vCloud Air builds - Build options for VMware and/or vCloud Air Vagrant artifacts Signed-off-by: Tom McPhail <tmcphail@vmware.com>
ghost
pushed a commit
that referenced
this pull request
Jun 5, 2015
ghost
pushed a commit
that referenced
this pull request
Apr 25, 2017
14MB compressed(bz2), 36MB uncompressed Extras: toybox: new package docker-image: uses toybox for core utils filesystem: provides and owns /var/run symlink Change-Id: Ic6e51b8e29c26f47a016cdd95a81e1ecd6d450b6 Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/2500 Tested-by: gerrit-photon <photon-checkins@vmware.com> Reviewed-by: Vinay Kulkarni <kulkarniv@vmware.com>
ghost
pushed a commit
that referenced
this pull request
Dec 12, 2019
Change-Id: Ida6431ce5a079e4e2b30ac2f8e31627ec671b497 Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/8665 Tested-by: gerrit-photon <photon-checkins@vmware.com> Reviewed-by: Priyesh Padmavilasom <ppadmavilasom@vmware.com> Reviewed-by: Alexey Makhalov <amakhalov@vmware.com>
gerrit-photon
pushed a commit
that referenced
this pull request
Mar 8, 2023
If wrong regex is given, then while parsing
regex we call cleanup_regex
- parse_task_ignore_string()
- compile_regex()
- cleanup_regex()
compiled = *compiled_expr;
if (compiled)
free(compiled);
- we doesn't reset the *compiled_expr variable after freeing
and it is extern variable
- again cleanup_regex() gets called from stalld.c
with already freed address(Non Null Address):
https://git.kernel.org/pub/scm/utils/stalld/stalld.git/tree/src/stalld.c?h=v1.18.0#n1307
- when we `systemctl restart stalld`, we get coredump:
which shows
systemd[1]: Stopping Stall Monitor...
systemd-coredump[780991]: Process 780670 (stalld) of user 0 dumped core.
Stack trace of thread 780670:
#0 0x00007f6becf1e041 raise (libc.so.6 + 0x3d041)
#1 0x00007f6becf07536 abort (libc.so.6 + 0x26536)
#2 0x00007f6becf5f5a8 n/a (libc.so.6 + 0x7e5a8)
#3 0x00007f6becf66fea n/a (libc.so.6 + 0x85fea)
#4 0x00007f6becf673dc n/a (libc.so.6 + 0x863dc)
#5 0x000055666563ed7e n/a (/usr/bin/stalld (deleted) + 0x6d7e)
systemd[1]: stalld.service: Main process exited, code=dumped, status=6/ABRT
systemd[1]: stalld.service: Failed with result 'core-dump'
- Resetting the extern variable to NULL after
freeing the memory solves this issue.
Change-Id: Ia75f4fea59476aea3b0aa267fdf0884f95f8b2e2
Signed-off-by: Ankit Jain <ankitja@vmware.com>
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19931
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Srivatsa S. Bhat <srivatsab@vmware.com>
gerrit-photon
pushed a commit
that referenced
this pull request
Mar 10, 2023
If wrong regex is given, then while parsing
regex we call cleanup_regex
- parse_task_ignore_string()
- compile_regex()
- cleanup_regex()
compiled = *compiled_expr;
if (compiled)
free(compiled);
- we doesn't reset the *compiled_expr variable after freeing
and it is extern variable
- again cleanup_regex() gets called from stalld.c
with already freed address(Non Null Address):
- when we `systemctl restart stalld`, we get coredump:
which shows
systemd[1]: Stopping Stall Monitor...
systemd-coredump[780991]: Process 780670 (stalld) of user 0 dumped core.
Stack trace of thread 780670:
#0 0x00007f6becf1e041 raise (libc.so.6 + 0x3d041)
#1 0x00007f6becf07536 abort (libc.so.6 + 0x26536)
#2 0x00007f6becf5f5a8 n/a (libc.so.6 + 0x7e5a8)
#3 0x00007f6becf66fea n/a (libc.so.6 + 0x85fea)
#4 0x00007f6becf673dc n/a (libc.so.6 + 0x863dc)
#5 0x000055666563ed7e n/a (/usr/bin/stalld (deleted) + 0x6d7e)
systemd[1]: stalld.service: Main process exited, code=dumped, status=6/ABRT
systemd[1]: stalld.service: Failed with result 'core-dump'
- Resetting the extern variable to NULL after
freeing the memory solves this issue.
Change-Id: Ia6bae7379970b5633194619d00c1d19adea120c2
Signed-off-by: Ankit Jain <ankitja@vmware.com>
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19968
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Srivatsa S. Bhat <srivatsab@vmware.com>
gerrit-photon
pushed a commit
that referenced
this pull request
Mar 10, 2023
If wrong regex is given, then while parsing
regex we call cleanup_regex
- parse_task_ignore_string()
- compile_regex()
- cleanup_regex()
compiled = *compiled_expr;
if (compiled)
free(compiled);
- we doesn't reset the *compiled_expr variable after freeing
and it is extern variable
- again cleanup_regex() gets called from stalld.c
with already freed address(Non Null Address):
- when we `systemctl restart stalld`, we get coredump:
which shows
systemd[1]: Stopping Stall Monitor...
systemd-coredump[780991]: Process 780670 (stalld) of user 0 dumped core.
Stack trace of thread 780670:
#0 0x00007f6becf1e041 raise (libc.so.6 + 0x3d041)
#1 0x00007f6becf07536 abort (libc.so.6 + 0x26536)
#2 0x00007f6becf5f5a8 n/a (libc.so.6 + 0x7e5a8)
#3 0x00007f6becf66fea n/a (libc.so.6 + 0x85fea)
#4 0x00007f6becf673dc n/a (libc.so.6 + 0x863dc)
#5 0x000055666563ed7e n/a (/usr/bin/stalld (deleted) + 0x6d7e)
systemd[1]: stalld.service: Main process exited, code=dumped, status=6/ABRT
systemd[1]: stalld.service: Failed with result 'core-dump'
- Resetting the extern variable to NULL after
freeing the memory solves this issue.
Change-Id: I18244692338599e0a0589c75a2714636bfd8a355
Signed-off-by: Ankit Jain <ankitja@vmware.com>
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19967
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Srivatsa S. Bhat <srivatsab@vmware.com>
tapakund
pushed a commit
that referenced
this pull request
Mar 20, 2023
If wrong regex is given, then while parsing
regex we call cleanup_regex
- parse_task_ignore_string()
- compile_regex()
- cleanup_regex()
compiled = *compiled_expr;
if (compiled)
free(compiled);
- we doesn't reset the *compiled_expr variable after freeing
and it is extern variable
- again cleanup_regex() gets called from stalld.c
with already freed address(Non Null Address):
- when we `systemctl restart stalld`, we get coredump:
which shows
systemd[1]: Stopping Stall Monitor...
systemd-coredump[780991]: Process 780670 (stalld) of user 0 dumped core.
Stack trace of thread 780670:
#0 0x00007f6becf1e041 raise (libc.so.6 + 0x3d041)
#1 0x00007f6becf07536 abort (libc.so.6 + 0x26536)
#2 0x00007f6becf5f5a8 n/a (libc.so.6 + 0x7e5a8)
#3 0x00007f6becf66fea n/a (libc.so.6 + 0x85fea)
#4 0x00007f6becf673dc n/a (libc.so.6 + 0x863dc)
#5 0x000055666563ed7e n/a (/usr/bin/stalld (deleted) + 0x6d7e)
systemd[1]: stalld.service: Main process exited, code=dumped, status=6/ABRT
systemd[1]: stalld.service: Failed with result 'core-dump'
- Resetting the extern variable to NULL after
freeing the memory solves this issue.
Change-Id: I18244692338599e0a0589c75a2714636bfd8a355
Signed-off-by: Ankit Jain <ankitja@vmware.com>
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19967
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Srivatsa S. Bhat <srivatsab@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom McPhail tmcphail@vmware.com