Fix values for host, port for proxy connection #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
pyVmomi/SoapAdapter.py
file. The change modifies theGetConnection
method to correctly set the tunnel using thehost
andport
attributes.The command
mitmproxy --showhost
was used to setup a proxy. Tested withpython3.11
on macOS 15.1.1.Leads to
The issue is rooted at:
pyvmomi/pyVmomi/SoapAdapter.py
Lines 1541 to 1542 in 9a8956f
pyvmomi/pyVmomi/SoapAdapter.py
Lines 1549 to 1555 in 9a8956f
Python documentation states
Line 1555 sets the the proxy host and port from line 1541 and 1542 as endpoint, which leads to the
Tunnel connection failed: 502 Bad Gateway
error. This should beself.host
(formatted) andself.port