Change password for BGP neighbor only on demand #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since password is not sent back from NSX for security reasons, it will not be present in state after import. In this scenario, we need to avoid the password from being cleared next time an update is triggered on the imported resource. Hence we only update the password if a change in this field s detected. Note that user can leave the password blank in configuration of the imported resource. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since password is not sent back from NSX for security reasons, it will not be present in state after import.
In this scenario, we need to avoid the password from being cleared next time an update is triggered on the imported resource. Hence we only update the password if a change in this field s detected. Note that user can leave the password blank in configuration of the imported resource.