fix: replace deprecated rand.Seed
#1436
Conversation
tenthirtyam
added
needs-review
Already did - but would rather wait to have a CI for acceptance tests before merging this (and few of the other changes). |
|
@vmware/terraform-provider-nsxt-maintainers: reminder. |
tenthirtyam
force-pushed
the
fix/replace-deprecated-rand.Seed
branch
from
fcf92c6 to
ca53e0b
Compare
`rand.Seed` has been deprecated since Go 1.20 and an alternative has been available since Go 1.0. As of Go 1.20 there is no reason to call `Seed` with a random value. Programs that call `Seed` with a known value to get a specific sequence of results should use `New(NewSource(seed))` to obtain a local random generator. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
force-pushed
the
fix/replace-deprecated-rand.Seed
branch
from
ca53e0b to
115a29e
Compare
|
@ksamoray If possible can we run acceptance tests for this PR, so we can merge it? |
|
@tenthirtyam, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
/test-all |
|
@tenthirtyam, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
/test-all |
Summary
rand.Seedhas been deprecated since Go 1.20 and an alternative has been available since Go 1.0.As of Go 1.20 there is no reason to call
Seedwith a random value. Programs that callSeedwith a known value to get a specific sequence of results should useNew(NewSource(seed))to obtain a local random generator.