Add proper host_switch_profile type with id, while setting in hostswitch #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annakhm
reviewed
Oct 24, 2024
| @@ -29,47 +31,56 @@ var ipAssignmentTypes = []string{ | |||
| "static_ip_pool", | |||
| } | |||
|
|
|||
| var mpTypeFromPolicyType = map[string]string{ | |||
There was a problem hiding this comment.
If the code assumes MP and Policy values are the same, do we need this translation?
There was a problem hiding this comment.
We query the host switch profile type using this policy API which returns policy types, e.g PolicyUplinkHostSwitchProfile.
The switch type consumes HostSwitchSpec type has host_switch_profile_id attribute which is a string - which is enumerated by HostSwitchProfileType that has no "Policy" prefix to its values. Hence translation is required even though it's not MP.
However mpTypeFromPolicyType name is bad - it's just HostSwitchProfileType translation and not any Policy->MP translation. I'll rename this var.
The code assumes that specified host_switch_profile is always of type uplink which is incorrect. Fixes: vmware#1441 Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
annakhm
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumes that specified host_switch_profile is always of type uplink which is incorrect.
Fixes: #1441