Add custom_url_partial_match to context profile #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
custom_url_partial_match
branch
from
30b2a8a
to
53a8eda
Compare
ksamoray
force-pushed
the
custom_url_partial_match
branch
from
53a8eda
to
79bb3f4
Compare
ksamoray
force-pushed
the
custom_url_partial_match
branch
4 times, most recently
from
510d6ed
to
af768df
Compare
|
Could we add a test for this? |
ksamoray
force-pushed
the
custom_url_partial_match
branch
4 times, most recently
from
53ca52a
to
b1fd5a2
Compare
|
/test-all |
annakhm
reviewed
Apr 11, 2023
| dependsOn := testAccNsxtPolicyContextProfileDependsOnTemplate("nsxt_policy_context_profile_custom_attribute.test") | ||
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t); testAccNSXVersion(t, "3.0.0") }, |
There was a problem hiding this comment.
should the version be 4.0.0 in this check?
ksamoray
force-pushed
the
custom_url_partial_match
branch
from
b1fd5a2
to
13f0315
Compare
Context profile attributes are missing custom_url_partial_match field which was added in NSX 4.0 Signed-off-by: Kobi Samoray <ksamoray@vmware.com>
ksamoray
force-pushed
the
custom_url_partial_match
branch
from
13f0315
to
be42079
Compare
|
/test-all |
annakhm
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context profile attributes are missing custom_url_partial_match field which was added in NSX 4.0