Improve TM testing support infrastructure #1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
commented
Nov 15, 2024
| @@ -1,4 +1,4 @@ | |||
| //go:build binary | |||
| //go:build binary && !tm | |||
There was a problem hiding this comment.
The test templates files that are in vcd/test-templates are not compatible with TM therefore this is not being executed when tm tag is specified
Didainius
commented
Nov 15, 2024
| @@ -99,11 +99,11 @@ function short_test { | |||
| fi | |||
| if [ -n "$VERBOSE" ] | |||
| then | |||
| echo "VCD_SHORT_TEST=1 go test -race -tags 'functional $MORE_TAGS' -v -timeout 5m" | |||
| echo "VCD_SHORT_TEST=1 go test -race -tags '$MORE_TAGS' -v -timeout 5m" | |||
There was a problem hiding this comment.
functional tag was default until TM, but this tag is now moved upstream to the function caller and it should be included within $MORE_TAGS in the caller. This allows for isolating functional tag that is not to be used with TM
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
reviewed
Nov 18, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testtm-acc,testtm-acc-coverage,make testtm-binary,make testtm-binary-prepareTESTING.mdfor TM testingsample_vcd_test_config.jsonfor VCD andsample_vcd_test_config_tm.jsonfor TM