Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to v2 Org VDC networks #816

Merged
merged 14 commits into from
Apr 7, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Apr 4, 2022

Created by #372

Depends on vmware/go-vcloud-director#459

This PR adds metadata support for the v2 VDC networks.

abarreiro added 7 commits April 4, 2022 09:30
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review April 5, 2022 08:25
@adambarreiro adambarreiro self-assigned this Apr 5, 2022
@adambarreiro adambarreiro removed the request for review from dataclouder April 5, 2022 08:25
abarreiro added 2 commits April 5, 2022 11:41
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Copy link
Collaborator Author

Checking an issue that TestAccVcdNetworkRoutedV2NsxtMigration showed. It seems metadata GET is failing when the network belongs to a VDC Group. So PR can't be merged as it is.

abarreiro added 4 commits April 6, 2022 12:29
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Copy link
Collaborator Author

Tests passed OK

@adambarreiro adambarreiro merged commit 2e3c387 into vmware:main Apr 7, 2022
@adambarreiro adambarreiro deleted the add-metadata-network-v2 branch April 7, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants