Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 202 as response code to "/v1/domains/{id}/resource-certificates" API endpoint #24

Merged

Conversation

dimitarproynov
Copy link
Contributor

Summary of Pull Request

The API at "/v1/domains/{id}/resource-certificates" responds with 202, breaking this SDK client. Include the reponse code.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

Testing done:
go mod tidy
go build

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

…es" API endpoint

The API at "/v1/domains/{id}/resource-certificates" responds with 202, breaking this SDK client. Include the reponse code.

Testing done:
go mod tidy
go build

Signed-off-by: Dimitar Proynov <proynovd@vmware.com>
@dimitarproynov dimitarproynov added the bug Bug label Nov 21, 2023
@dimitarproynov dimitarproynov added this to the Backlog milestone Nov 21, 2023
@dimitarproynov dimitarproynov self-assigned this Nov 21, 2023
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Nov 21, 2023
@dimitarproynov dimitarproynov merged commit 188f83f into main Nov 21, 2023
2 checks passed
@tenthirtyam tenthirtyam deleted the feature/include_202_response_to_resource_certificates branch December 15, 2023 18:44
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Dec 15, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
@tenthirtyam tenthirtyam removed this from the Backlog milestone Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants