Added that ugrade script now supports appliance FQDN #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuclem
reviewed
May 14, 2019
| @@ -61,7 +61,7 @@ For information about the supported upgrade paths for all versions of vSphere In | |||
| 7. Provide information about the old version of the appliance. | |||
|
|
|||
| 1. Enter the name of the datacenter that contains the old version of the appliance. | |||
| 2. Enter the IP address of the old version of the appliance.The upgrade script does not accept FQDN addresses for the old appliance. | |||
| 2. Enter the IP address or FQDN of the old version of the appliance. | |||
There was a problem hiding this comment.
I think that we need to mention that FQDN is only accepted from 1.5.3 onwards...
There was a problem hiding this comment.
Thanks @stuclem . Made the change.
stuclem
reviewed
May 16, 2019
| @@ -61,7 +61,7 @@ For information about the supported upgrade paths for all versions of vSphere In | |||
| 7. Provide information about the old version of the appliance. | |||
|
|
|||
| 1. Enter the name of the datacenter that contains the old version of the appliance. | |||
| 2. Enter the IP address of the old version of the appliance.The upgrade script does not accept FQDN addresses for the old appliance. | |||
| 2. Enter the IP address or FQDN of the old version of the appliance. You can only enter the FQDN for vSphere Integrated Containers 1.5.3 and later versions. For earlier versions, enter the IP address. | |||
There was a problem hiding this comment.
I think that in 1.5.3 and onwards you can enter either the FQDN or the IP address....
There was a problem hiding this comment.
Thanks, @stuclem . I have updated it.
stuclem
approved these changes
May 22, 2019
|
Thanks, Stuart! |
|
Per comment from @renmaosheng in #1731 (comment), we apparently haven't fixed this in 1.5.3. My mistake! @vidya-v I am reverting this PR following instruction from Steven. |
stuclem
added a commit
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stuclem ,
Modified https://vmware.github.io/vic-product/assets/files/html/1.5/vic_vsphere_admin/upgrade_appliance.html to include support for appliance FQDN.
Fixes #2422
Request your review.
Thanks,
Vidya