Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the endpoint to fetch the hosts of a VDS #525

Conversation

javierfz1980
Copy link
Contributor

This change will fix the endpoint to fetch the hosts of a VDS during VCH Creation Wizard in the Networ step. The new endpoint will be /ui/vic/rest/data/properties and it will be handled by our own vic java service layer.

Fixes #504

PR acceptance checklist:

[ x ] All unit tests pass
[ x ] All e2e tests pass
[ x ] Unit test(s) included*
[ n/a ] e2e test(s) included*
[ n/a ] Screenshot attached and UX approved*

*if applicable, add n/a if not

This change will fix the endpoint to fetch the hosts of a VDS during VCH Creation Wizard in the Networ step. The new endpoint will be /ui/vic/rest/data/properties and it will be handled by our own vic java service layer.
Copy link
Contributor

@lmalvins lmalvins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javierfz1980 javierfz1980 merged commit 0fc48d8 into vmware:develop Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants