Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit code 137 reported instead of 143 for a migrated container #5653

Open
3 tasks
hickeng opened this issue Jul 6, 2017 · 2 comments
Open
3 tasks

Exit code 137 reported instead of 143 for a migrated container #5653

hickeng opened this issue Jul 6, 2017 · 2 comments
Labels
component/portlayer/execution component/portlayer kind/defect Behavior that is inconsistent with what's intended priority/p2

Comments

@hickeng
Copy link
Member

hickeng commented Jul 6, 2017 •
edited
Loading

Follow on from #5610 which exposes a problem with the exit code reporting for migrated containers. This is due to us not clearing the started field during the stop path when the container is migrated.

Story
As a VIC developer I expect even migrated containers to have their ExtraConfig state re-initialized appropriately on the start and stop paths.

Detail
We refuse to write changes to configuration back to a migrated container, however we still need to be able to re-initialize that containers state for start & stop operations.
This will require us to add knowledge as to what re-initialize means for a given container data version and call that from the commit logic.

Currently we should also observe that subsequent starts of a migrated container will not block until the process is launched, but will return immediately - this is due to the old status being preserved.

Acceptance

  • re-enable the exit code checks in 11-01-Upgrade
  • exit code is reported correctly for migrated containers
  • second start of a migrated container blocks as expected until process has launched
hickeng added a commit to hickeng/vic that referenced this issue Jul 6, 2017
@hickeng
Correct handle refresh behaviour for power off
34f73df 
Ensures that the handle refresh on the power off path gets updated
extraconfig data from the VM.
Adjusts the syslog queue size to deal with excessive overflows.
Disables the exit code check for migrated containers until vmware#5653 is
addressed.
hickeng added a commit to hickeng/vic that referenced this issue Jul 7, 2017
@hickeng
Correct handle refresh behaviour for power off
bb6bf09 
Ensures that the handle refresh on the power off path gets updated
extraconfig data from the VM.
Adjusts the syslog queue size to deal with excessive overflows.
Disables the exit code check for migrated containers until vmware#5653 is
addressed.
hickeng added a commit that referenced this issue Jul 10, 2017
@hickeng
Reduce incidence of #5445 (#5532)
7738cb5 
* Updates extraconfig logging config
* Fixes syslogd configuration and reduces some log verbosity
* Adds support for delta sets of extraconfig keys
* Stops overwriting exit code on CLI stop call
* Generate stop event after state refresh to get consistent state
* Adjusts the syslog queue size to deal with excessive overflows.
* Correct handle refreshFromHandle behaviour on the power off path.
* Disables the exit code check for migrated containers until #5653 is
addressed.
@mdubya66 mdubya66 added the kind/defect Behavior that is inconsistent with what's intended label Jul 31, 2017
@cgtexmex cgtexmex self-assigned this Aug 2, 2017
@cgtexmex cgtexmex added this to the Sprint 14 milestone Aug 2, 2017
@mdubya66 mdubya66 removed this from the Sprint 14 milestone Aug 15, 2017
@cgtexmex cgtexmex self-assigned this Aug 16, 2017
@cgtexmex cgtexmex added this to the Sprint 15 milestone Aug 16, 2017
@mdubya66
Copy link
Contributor

removing from 1.2. Not a stop shipper.

@mdubya66 mdubya66 removed this from the Sprint 15 milestone Aug 17, 2017
@anchal-agrawal
Copy link
Contributor

Related: #6614

@hickeng hickeng mentioned this issue Mar 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/portlayer/execution component/portlayer kind/defect Behavior that is inconsistent with what's intended priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cgtexmex @hickeng @anchal-agrawal @mdubya66