Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support templated naming convention for containerVMs #6267

Closed
hickeng opened this issue Sep 11, 2017 · 3 comments
Closed

Support templated naming convention for containerVMs #6267

hickeng opened this issue Sep 11, 2017 · 3 comments
Labels
area/vsphere Intergration and interoperation with vSphere component/install kind/enhancement Behavior that was intended, but we want to make better source/customer Reported by a customer, directly or via an intermediary

Comments

@hickeng
Copy link
Member

hickeng commented Sep 11, 2017

Story
As a viadmin I want to be able to enforce a naming convention for cVMs to support chargeback and other organization requirements

Detail
Container naming convention applies to the vSphere VM displayName, not to the container name itself.

@hickeng
Copy link
Member Author

hickeng commented Sep 11, 2017

#6265 is a very early and not formally tested PR with basic naming convention support. The only replaceable token is {name} and that will be replace with either:
a. the name provided with docker create
b. a generated name as when --name is omitted from docker create

@hickeng hickeng added source/customer Reported by a customer, directly or via an intermediary kind/enhancement Behavior that was intended, but we want to make better area/vsphere Intergration and interoperation with vSphere component/install labels Sep 11, 2017
@hickeng hickeng added the impact/doc/note Requires creation of or changes to an official release note label Sep 28, 2017
@hickeng
Copy link
Member Author

hickeng commented Sep 28, 2017

@stuclem
A very basic form of this has been merged for engine 1.2.1 to address an urgent need. #6332 is open to polish and complete the work and has more detail than this issue, so closing in favour.
Current mechanism adds the --cnc or --container-name-convention option. This takes a name template of the form some_fixed_pattern_{replace-with-value}-static-suffix - basically just a static string conforming to existing VM naming restrictions with some replaceable tokens. Current tokens are:

  • {name} - the docker pretty name for the container (either generated or supplied by docker run --name=some-name)
  • {id} - the shortID of the container

This convention applies only to the vSphere display name of the VM and does not impact the names known and shown by docker.

@stuclem stuclem removed the impact/doc/note Requires creation of or changes to an official release note label Oct 3, 2017
@hickeng
Copy link
Member Author

hickeng commented Oct 9, 2017

As noted but not done in previous comment, closing in favour of #6332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere Intergration and interoperation with vSphere component/install kind/enhancement Behavior that was intended, but we want to make better source/customer Reported by a customer, directly or via an intermediary
Projects
None yet
Development

No branches or pull requests

2 participants