Adds basic name convention support [full ci] #6265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6159) This change borrows the specific ci logic to run only Group11-Upgrade and 7-01-Regression tests on a tag build (tag event on a *refs/tags* branch).
…rt (vmware#6160) (vmware#6194) Adding gateway address for bridge networks on VCH restart
We were not reinitializing session status on out-of-band power operations, meaning we hit a filter in the launch logic that skipped launching the container process. Additional tests to follow
Cherry pick of vmware/govmomi#829 master branch has this change via the full govmomi update in vmware#6144 Fixes vmware#6152
It was possible for the Stop() method close the RPC channels when the main loop was in the middle of Send/Receive.
includes govmomi 0.15.0
hickeng
force-pushed
the
rename-alternatives
branch
from
28f4251 to
8946236
Compare
hickeng
force-pushed
the
rename-alternatives
branch
from
8946236 to
61fec99
Compare
Provides basic container naming convention via {id} and {name} tokens.
The naming is enforced only on vSphere and will not be visible via
the docker client.
mhagen-vmware
suggested changes
Sep 12, 2017
| @@ -113,6 +114,7 @@ Upgrade VCH with Harbor On HTTP | |||
| Test VCH And Registry %{VCH-IP}:%{VCH-PORT} ${harbor_ip} | |||
|
|
|||
| Upgrade VCH with Harbor On HTTPS | |||
| Pass Execution Need to use a different insecure registry, because Harbor does not support VIC as insecure and 0.5.0 is too old | |||
| ${out}= Cleanup Harbor ${http_harbor_name} | |||
| Log ${out} | |||
| ${out}= Cleanup Harbor ${https_harbor_name} | |||
There was a problem hiding this comment.
bed merge? This is in master already..
|
I think this can just be closed in favor of #6284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds redo logic for concurrent modifications to the rename path
Adds very basic naming convention mechanism
Does not add tests or reconfigure support for the new option.
Updates needed in priority order:
{id}(shortID) as a token as well as{name}- name could be omitted in initial supportEnd goal is:
vSphere display name like
cVM_prod-short_id, from a convention template ofcVM_prod-{id}container name as normal, like
random_namedocker renamedoes not impact vsphere display name unless{name}is used in convention