Free'ing address space on scope delete #6106
Conversation
| } | ||
|
|
||
| if p.Parent != nil { | ||
| p.Parent.ReleaseIP4Range(p) |
There was a problem hiding this comment.
here has a check for if Parent is nil:
https://github.com/vmware/vic/blob/master/lib/portlayer/network/ipam.go#L334
Does that create problem?
|
|
||
| var parentSpace *AddressSpace | ||
| if len(s.spaces) == 1 { | ||
| parentSpace = s.spaces[0] |
There was a problem hiding this comment.
just curious why don't get parent space here?
There was a problem hiding this comment.
in the case where len(s.spaces) == 1, the only space in the slice is the parent. See this case here: https://github.com/vmware/vic/blob/master/lib/portlayer/network/context.go#L443
lib/portlayer/network/context.go
Outdated
| @@ -1258,6 +1258,35 @@ func (c *Context) DeleteScope(ctx context.Context, name string) error { | |||
| return fmt.Errorf("%s has active endpoints", s.Name()) | |||
| } | |||
|
|
|||
| var allzeros, allones net.IP | |||
There was a problem hiding this comment.
Nit: allZeros, allOnes.
|
|
||
| log "github.com/Sirupsen/logrus" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/mock" | ||
|
|
||
| "math/rand" |
There was a problem hiding this comment.
We should put this in the top import group.
hmahmood
force-pushed
the
network-rm-fix
branch
2 times, most recently
from
179de54 to
8417a05
Compare
| @@ -69,3 +69,17 @@ Remove network with running container | |||
| ${rc} ${output}= Run And Return Rc And Output docker %{VCH-PARAMS} network ls | |||
| Should Be Equal As Integers ${rc} 0 | |||
| Should Not Contain ${output} test-network | |||
|
|
|||
| Add and remove network multiple times | |||
There was a problem hiding this comment.
Prefer naming this - Verify user can create and delete many networks
There was a problem hiding this comment.
Its creating and deleting the same network over and over again, not creating a new network each time.
hmahmood
force-pushed
the
network-rm-fix
branch
from
8417a05 to
cfe58a5
Compare
Fixes #4157