Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker pull on docker store fails #8138

Closed
sflxn opened this issue Jul 10, 2018 · 6 comments · Fixed by #8140
Closed

Docker pull on docker store fails #8138

sflxn opened this issue Jul 10, 2018 · 6 comments · Fixed by #8140
Assignees
@sflxn
Labels
area/docker Support for the Docker operations component/imagec impact/doc/kb Requires creation of or changes to an official knowledge base article priority/p1 source/customer Reported by a customer, directly or via an intermediary

Comments

@sflxn
Copy link
Contributor

sflxn commented Jul 10, 2018 •
edited
Loading

Docker pull on images on docker store fails. For instance,

docker pull store/ibmcorp/db2wh_ce:v2.9.0-db2wh_client-linux

Internal bug 2152747.
@sflxn sflxn added area/docker Support for the Docker operations component/imagec labels Jul 10, 2018
@sflxn sflxn self-assigned this Jul 10, 2018
@sflxn
Copy link
Contributor Author

sflxn commented Jul 12, 2018

I found the cause of this issue. We changed the default registry URL from registry-1.docker.io to registry.hub.docker.com as part of the content trust work. I didn't work on that and have no knowledge of it, and the people who made the changes do not remember why we made the change. In any case registry-1 is actually hardcoded in docker's code so I think we can just change it back and see if our ci build complains during the content trust tests.

I've also fixed a bug in the fetcher pertaining to interpretation of unauthorized access. It was presenting an improper error message leading me down the wrong path during debugging. We should now return access denied, which the docker registry code also returns.

sflxn pushed a commit to sflxn/vic that referenced this issue Jul 12, 2018
[WIP] Fixed pull against docker store
0ba864e 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

```
[full ci]
[parallel jobs=4]
```

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 12, 2018
[WIP] Fixed pull against docker store
f9516d7 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

```
[full ci]
[parallel jobs=4]
```

Fixes vmware#8138
@sflxn sflxn mentioned this issue Jul 12, 2018
Merged
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 12, 2018
[WIP] Fixed pull against docker store
befd07f 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 12, 2018
[WIP] Fixed pull against docker store
7ff2f94 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 12, 2018
[WIP] Fixed pull against docker store
fba796b 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 12, 2018
[WIP] Fixed pull against docker store
04b1290 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 13, 2018
[WIP] Fixed pull against docker store
e0b95c0 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 13, 2018
[WIP] Fixed pull against docker store
4673776 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 16, 2018
[WIP] Fixed pull against docker store
53998c3 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Jul 16, 2018
[WIP] Fixed pull against docker store
721e62e 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
@renmaosheng renmaosheng added source/customer Reported by a customer, directly or via an intermediary priority/p1 labels Jul 17, 2018
sflxn pushed a commit to sflxn/vic that referenced this issue Aug 6, 2018
[WIP] Fixed pull against docker store
15732be 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Aug 9, 2018
[WIP] Fixed pull against docker store
e3c08ae 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
sflxn pushed a commit to sflxn/vic that referenced this issue Aug 15, 2018
Fixed pull against docker store
c693e29 
We changed the default docker registry URL back when we were
adding content trust.  That URL is causing this failure.  The
URL has been changed back to the same value that is hardcoded
in the docker distribution code.

Also fixed an error interpretation in the fetcher code to match
Docker's interpretation.  We were returning image not found
when the actual error was access denied.  This led the debugging
of this issue down the wrong path and will eventually lead us
down the wrong path with future bugs.

Fixes vmware#8138
@stuclem
Copy link
Contributor

stuclem commented Aug 17, 2018

@sflxn do we need to document this?

@stuclem stuclem closed this as completed Aug 17, 2018
@stuclem stuclem reopened this Aug 17, 2018
@stuclem
Copy link
Contributor

stuclem commented Aug 17, 2018 •
edited
Loading

Sorry about the accidental close!

@zjs zjs added the impact/doc/note Requires creation of or changes to an official release note label Sep 13, 2018
@zjs
Copy link
Member

zjs commented Sep 13, 2018

do we need to document this?

I think it's worth a release note, as it's something customers had reported as broken, but I don't think it needs to be mentioned in the user documentation.

@stuclem
Copy link
Contributor

stuclem commented Sep 17, 2018

Added as a resolved issue in https://github.com/vmware/vic/releases/tag/v1.4.3

@stuclem stuclem removed the impact/doc/note Requires creation of or changes to an official release note label Sep 17, 2018
@dbarkelew dbarkelew added the impact/doc/kb Requires creation of or changes to an official knowledge base article label Sep 17, 2018
@dbarkelew
Copy link

https://kb.vmware.com/s/article/56634 will also need to be updated once the fix is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sflxn sflxn

Labels
area/docker Support for the Docker operations component/imagec impact/doc/kb Requires creation of or changes to an official knowledge base article priority/p1 source/customer Reported by a customer, directly or via an intermediary
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed pull against docker store sflxn/vic
5 participants
@zjs @sflxn @renmaosheng @stuclem @dbarkelew