[skip ci] Remove dangling container during network rm #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengwang86
changed the title
chengwang86
changed the title
matthewavery
reviewed
Sep 4, 2017
| // remove dangling endpoints | ||
| if exec.Containers != nil { | ||
| for _, eps := range s.Endpoints() { | ||
| if exec.Containers.Container(eps.ID().String()) == nil { |
There was a problem hiding this comment.
small nit: instead of calling eps.ID().String() 3 times here you could assign it a variable once and then just use that variable instead :) will make the code a little more friendly to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5948 .
The reason we observe
network has active endpointsfailure duringdocker-compose downis because that a container is already removed from the PL container cached but still exists in the network layer container cache. We refer to such a container as adanglingcontainer on the network.In this PR, when
network rmis called, we remove these dangling containers (if any).