[specific ci=1-14-Docker-Kill] publish containerPoweredOff event after kill #6206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5948
This PR should be able to at least alleviate the failure seen in our recent compost tests.
In the issue, when the VMPoweredOff event was to be processed, the container had already been removed from cache; therefore, we couldn't unbind the container from network. In this PR, we publish the containerPoweredOff event as soon as it is killed. This should guarantee that the container can be unbound from network most of the time. But it still does not fully resolve the race condition.
I think the race condition revealed by the compose test is quite general in our code and we need a comprehensive design for how to handle the async events, instead of changing our current logic for
network rm
and/orcontainer rm
as a fix.