Possible fix for subclassing of Ref<> stuff

[ellenhp]

I think this might fix an issue mux is having that he mentioned in rocket.chat. Needs testing.

[BastiaanOlij]

Owh I'll test that out later today, that looks like it could indeed fix my issue :)

[BastiaanOlij]

Hmmm, close but I'm getting this compile warning now:
godot-cpp\include\godot_cpp\classes\ref.hpp(170) : warning C4717: 'godot::Ref<godot::XRInterface>::Ref<godot::XRInterface><godot::XRInterfaceReference>': recursive on all control paths, function will cause runtime stack overflow

So I think it's still missing something...

[BastiaanOlij]

Trying out the same code as in Godot:

	template <class T_Other>
	Ref(const Ref<T_Other> &p_from) {
		RefCounted *refb = const_cast<RefCounted *>(static_cast<const RefCounted *>(p_from.ptr()));
		if (!refb) {
			unref();
			return;
		}
		Ref r;
		r.reference = Object::cast_to<T>(refb);
		ref(r);
		r.reference = nullptr;
	}

Results in the compile warning to go away but it still crashes on casting. Looks like something is getting mixed up in wrapping the class....

[vnen]

Trying out the same code as in Godot:

I believe both constructors should exist: one for the same type and one for the different types. Not sure why I removed it when getting the code from Godot, probably missed it by accident.

[ellenhp]

Superseded by #21