Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul of build & testing system; bugfixes #19

Merged
merged 32 commits into from
Nov 30, 2018
Merged

Overhaul of build & testing system; bugfixes #19

merged 32 commits into from
Nov 30, 2018

Conversation

TheCount
Copy link

@TheCount TheCount commented Nov 7, 2018

This pull request mainly addresses #17.

About the GNU coding standards: I tried to use them once I saw your comment #16 (comment), but older commits may be broken in this respect; sorry.

I've rebased my changes against your master, so it should apply cleanly.

Here is a list of changes:

  • Switched to CMake. Works on GNU/Linux and OSX with both gcc and clang. With some restrictions, it also works on Windows with Visual Studio 2017. Removed the old build system.
  • Removed legacy code not needed in ANSI-C compatible environments.
  • Moved docs to separate directory.
  • Split up the *.tst.in files into separate test files.
  • Massive deduplication in test code.
  • Fixed a bug where a visitation flag would be undone in every other traversal (22ac876).
  • Fixed an uninitialised memory bug (e346117).
  • Fixed an invalid memory access bug (c362150).

Still open:

  • The test CMakeLists.txt are quite bulky. I'd like to rename the tests to speaking names instead of just test42.c before addressing this.
  • Reliance on bash, so not all tests can be run on Windows.
  • With Visual Studio, there is a bug where sometimes the dependency on sgramm.c is not resolved. I have no idea what causes this. Can be fixed by building the sgramm_c target explicitly first.
  • Docs could maybe be generated instead of just lying around.

I think these still open issues have lower priority and I would leave them for later.

TheCount added 30 commits November 7, 2018 22:27
@TheCount
cocom-config.h.in: remove cruft
2c8595a 
Remove everything that is either not used at all or guaranteed by C90
anyway.
@TheCount
Remove unneeded endianness check
cadb6d6
@TheCount
Ignore out-of-tree build directories
62189e4
@TheCount
Start out-of-tree build with CMake
ccae017
@TheCount
Also build C++ library
6c8f0a1
@TheCount
Remove dependency on cocom-config.h
c4d4fd4
@TheCount
Install headers and static libraries
fef66e4
@TheCount
Move documentation into separate subdirectory
82754ba
@TheCount
Install documentation
f282b20
@TheCount
Move ticker files to separate test directory
c723438 
Tickers are used for testing/benchmarking only, so they can go into a
separate directory.
@TheCount
Build static ticker library for testing
10315e9
@TheCount
Break up compare_parsers.tst.in
8ce4404 
Break up compare_parsers.tst.in into separate test directory
@TheCount
Break up yaep.tst.in
db5ec0d 
Break up yaep.tst.in into individual files and create individual tests.
@TheCount
Explicitly mark generated libraries as static
ccdcb83
@TheCount
Add ticker C++ library
019c2c9
@TheCount
Break up yaep++.tst.in
dc187ca 
Break up yaep++.tst.in into individual files and create individual
tests.
@TheCount
Remove remnants of old build system
1cef350
@TheCount
Test new build system on TravisCI
0356a79
@TheCount
Have C and C++ output matching error messages
943522e
@TheCount
Deduplicate test data files
11e08d4
@TheCount
Deduplicate ANSI C tokenizer
410699a
@TheCount
Remove dead code
e001daa
@TheCount
Bugfix: do not undo visit flag on second traversal
22ac876
@TheCount
C tests: deduplicate parse tree memory management
fe8000c
@TheCount
C tests: deduplicate test_syntax_error()
22418e9
@TheCount
C tests: deduplicate test_read_token()
c977d89
@TheCount
C tests: deduplicate some test mains
dd50c88 
Deduplicate standard yaep_parse_grammar() type tests.
@TheCount
C tests: deduplicate some test mains
05a776d 
Deduplicate standard yaep_read_grammar() type tests.
@TheCount
C tests: deduplicate some test mains
a70cbd2 
Deduplicate most more complex mains.
@TheCount
C++ tests: deduplication
243f8e9 
Perform analogous deduplications as in
52a15f0,
b931e20,
8e37c71,
a649673,
99e6bb4, and
37d7b4a.
@TheCount
Bugfix: properly init OS::initial_segment_length
e346117
@TheCount
Bugfix: avoid out-of-bounds access
c362150 
Avoid out-of-bounds access of symb_code_trans_vect when an unknown
terminal appears in the input (see test19).
@TheCount TheCount mentioned this pull request Nov 10, 2018
Merged
@vnmakarov vnmakarov merged commit c362150 into vnmakarov:master Nov 30, 2018
@sanssecours sanssecours mentioned this pull request Dec 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheCount @vnmakarov